Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Rename SunshineTestBase class to ClasspathBasedTest #155

Merged
merged 1 commit into from
Jan 13, 2019
Merged

Rename SunshineTestBase class to ClasspathBasedTest #155

merged 1 commit into from
Jan 13, 2019

Conversation

extsoft
Copy link
Member

@extsoft extsoft commented Jan 13, 2019

The change is made to build more obvious and unambiguous namespace.

The rename was made using deprecation mechanism. This means the old
class is still available, however, a new one is used in the code.

#137

The change is made to build more obvious and unambiguous namespace.

The rename was made using deprecation mechanism. This means the old
class is still available, however, a new one is used in the code.

#137
@codecov
Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #155 into master will increase coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     70.43%   70.45%   +0.01%     
- Complexity      112      115       +3     
============================================
  Files            46       47       +1     
  Lines           504      511       +7     
  Branches          7        7              
============================================
+ Hits            355      360       +5     
- Misses          145      147       +2     
  Partials          4        4
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/org/tatools/sunshine/core/Test.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/tatools/sunshine/core/SunshineTest.java 71.42% <ø> (ø) 0 <0> (ø) ⬇️
...a/org/tatools/sunshine/core/SunshineSuiteBase.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/tatools/sunshine/testng/TestNGTest.java 75% <100%> (ø) 3 <1> (ø) ⬇️
.../org/tatools/sunshine/core/ClasspathBasedTest.java 55.55% <55.55%> (ø) 3 <3> (?)
...va/org/tatools/sunshine/core/SunshineTestBase.java 71.42% <75%> (+15.87%) 3 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabd6f5...e33cba4. Read the comment docs.

@extsoft
Copy link
Member Author

extsoft commented Jan 13, 2019

@rultor please merge.

@rultor
Copy link
Collaborator

rultor commented Jan 13, 2019

@rultor please merge.

@extsoft OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e33cba4 into master Jan 13, 2019
@extsoft extsoft deleted the 137 branch January 13, 2019 19:58
@rultor
Copy link
Collaborator

rultor commented Jan 13, 2019

@rultor please merge.

@extsoft Done! FYI, the full log is here (took me 3min)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants