Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: provide connection details in getting started (fixes #2838) #2897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fgozdz
Copy link
Contributor

@fgozdz fgozdz commented Nov 12, 2024

This issue fixes #2838

@fgozdz fgozdz requested a review from manast November 12, 2024 12:55
@fgozdz fgozdz changed the title fix(docs): provide connection details in getting started (fixes #2847) fix(docs): provide connection details in getting started (fixes #2838) Nov 12, 2024
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roggervalf roggervalf changed the title fix(docs): provide connection details in getting started (fixes #2838) docs: provide connection details in getting started (fixes #2838) Nov 12, 2024
@@ -25,7 +25,7 @@ const myWorker = new Worker('myqueue', async (job)=>{}, { connection: {
import { Queue, Worker } from 'bullmq';
import IORedis from 'ioredis';

const connection = new IORedis();
const connection = new IORedis({ maxRetriesPerRequest: null });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something to take in count is that we are recommending to not ass this option for producers (Queue), only for consumers (Workers). Pls change it to reflect it base on https://docs.bullmq.io/bull/patterns/persistent-connections#queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Getting started documentation doesn't run
3 participants