fix(metrics): differentiate points in different minutes to be more ac…

…curate (#2766) (python)
taskforcesh · Sep 10, 2024 · 7cb670e · 7cb670e
1 parent a8cb8a2
commit 7cb670e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/commands/includes/collectMetrics.lua b/src/commands/includes/collectMetrics.lua
@@ -17,7 +17,7 @@ local function collectMetrics(metaKey, dataPointsList, maxDataPoints,
         return
     end
 
-    local N = math.min(math.floor((timestamp - prevTS) / 60000), tonumber(maxDataPoints))
+    local N = math.min(math.floor(timestamp / 60000) - math.floor(prevTS / 60000), tonumber(maxDataPoints))
 
     if N > 0 then
         local delta = count - rcall("HGET", metaKey, "prevCount")

diff --git a/tests/test_metrics.ts b/tests/test_metrics.ts
@@ -66,6 +66,8 @@ describe('metrics', function () {
       ONE_MINUTE,
       ONE_MINUTE,
       ONE_MINUTE * 3,
+      ONE_SECOND * 70,
+      ONE_SECOND * 50,
       ONE_HOUR,
       ONE_MINUTE,
     ];
@@ -132,6 +134,8 @@ describe('metrics', function () {
       '0',
       '0',
       '1',
+      '1',
+      '1',
       '0',
       '0',
       '1',