fix(GoalCriteria): hide action dropdown

taskany-inc · Jul 19, 2023 · b5e00cc · b5e00cc
1 parent 0827d8b
commit b5e00cc
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/components/GoalCriteria/GoalCriteria.tsx b/src/components/GoalCriteria/GoalCriteria.tsx
@@ -246,7 +246,7 @@ const criteriaGuard = (props: GoalCriteriaItemProps): props is CriteriaAsGoalPro
 
 type CriteriaActionItem = {
     label: string;
-    onClick: () => void;
+    handler: () => void;
     color?: string;
     icon: React.ReactNode;
 };
@@ -293,20 +293,24 @@ const GoalCriteriaItem: React.FC<GoalCriteriaItemProps> = memo((props) => {
             actions.push({
                 label: tr('Create as goal'),
                 icon: <IconTargetOutline size="xxs" />,
-                onClick: onConvertToGoal,
+                handler: onConvertToGoal,
             });
         }
 
         actions.push({
             label: tr('Delete'),
             icon: <IconXCircleSolid size="xxs" />,
             color: danger0,
-            onClick: onRemove,
+            handler: onRemove,
         });
 
         return actions;
     }, [canEdit, onRemove, props, onConvertToGoal]);
 
+    const handleChange = useCallback((val: CriteriaActionItem) => {
+        val.handler();
+    }, []);
+
     return (
         <StyledTableRow>
             {criteriaGuard(props) ? (
@@ -342,12 +346,13 @@ const GoalCriteriaItem: React.FC<GoalCriteriaItemProps> = memo((props) => {
             <ContentItem>
                 {nullable(availableActions, (actions) => (
                     <Dropdown
+                        onChange={handleChange}
                         renderTrigger={({ onClick }) => <IconMoreVerticalOutline size="xs" onClick={onClick} />}
                         items={actions}
                         renderItem={(props) => (
                             <MenuItem
                                 key={props.index}
-                                onClick={props.item.onClick}
+                                onClick={props.onClick}
                                 icon={props.item.icon}
                                 ghost
                                 color={props.item.color}