fix(FilterPresetForm): simplify api

taskany-inc · Oct 13, 2023 · 50be538 · 50be538
1 parent 7775e23
commit 50be538
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/components/FilterCreateForm/FilterCreateForm.tsx b/src/components/FilterCreateForm/FilterCreateForm.tsx
@@ -6,8 +6,6 @@ import * as Sentry from '@sentry/nextjs';
 
 import { errorsProvider } from '../../utils/forms';
 import { createFilterSchema, CreateFilter } from '../../schema/filter';
-import { Nullish, Void } from '../../types/void';
-import { FilterById } from '../../../trpc/inferredTypes';
 import { useFilterResource } from '../../hooks/useFilterResource';
 import { ModalEvent, dispatchModalEvent } from '../../utils/dispatchModal';
 
@@ -17,7 +15,7 @@ interface FilterCreateFormProps {
     mode: CreateFilter['mode'];
     params: CreateFilter['params'];
 
-    onSubmit?: Void<Nullish<FilterById>>;
+    onSubmit?: (id: string) => void;
 }
 
 const FilterCreateForm: React.FC<FilterCreateFormProps> = ({ mode, params, onSubmit }) => {
@@ -48,7 +46,7 @@ const FilterCreateForm: React.FC<FilterCreateFormProps> = ({ mode, params, onSub
             const [data, err] = await createFilter(form);
 
             if (data && !err) {
-                onSubmit?.(data);
+                onSubmit?.(data.id);
             }
         },
         [createFilter, onSubmit],

diff --git a/src/components/FilterDeleteForm/FilterDeleteForm.tsx b/src/components/FilterDeleteForm/FilterDeleteForm.tsx
@@ -11,7 +11,7 @@ import { tr } from './FilterDeleteForm.i18n';
 interface FilterDeleteFormProps {
     preset: FilterById;
 
-    onSubmit: (preset: FilterById) => void;
+    onSubmit: (params: string) => void;
     onCancel: () => void;
 }
 
@@ -23,7 +23,7 @@ const FilterDeleteForm: React.FC<FilterDeleteFormProps> = ({ preset, onSubmit, o
             const [data, err] = await deleteFilter(preset.id);
 
             if (data) {
-                onSubmit(preset);
+                onSubmit(preset.params);
             } else if (err) {
                 Sentry.captureException(err);
             }