fix: e2e on dashboard and projects pages

taskany-inc · Aug 12, 2024 · 4bca886 · 4bca886
1 parent a703395
commit 4bca886
Show file tree

Hide file tree

Showing 7 changed files with 134 additions and 53 deletions.
diff --git a/cypress/e2e/dashboard.cy.ts b/cypress/e2e/dashboard.cy.ts
@@ -102,16 +102,11 @@ describe('User dashboard', () => {
         });
 
         it("user can create goal from projects's list", () => {
-            const translations = getTranslation({
-                InlineCreateGoalControl: ['Create goal'],
-            });
             cy.get(projectListItem.query).should('not.exist');
 
             cy.get(filtersPanelResetButton.query).should('exist').click().should('not.exist');
 
-            cy.get(projectListItem.query)
-                .find(createGoalInlineControl.query)
-                .and('include.text', translations.InlineCreateGoalControl['Create goal']());
+            cy.get(projectListItem.query).find(createGoalInlineControl.query).and('not.include.text');
         });
 
         after(() => {

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/components/InlineCreateGoalControl/InlineCreateGoalControl.i18n/en.json b/src/components/InlineCreateGoalControl/InlineCreateGoalControl.i18n/en.json
diff --git a/src/components/InlineCreateGoalControl/InlineCreateGoalControl.i18n/index.ts b/src/components/InlineCreateGoalControl/InlineCreateGoalControl.i18n/index.ts
diff --git a/src/components/InlineCreateGoalControl/InlineCreateGoalControl.i18n/ru.json b/src/components/InlineCreateGoalControl/InlineCreateGoalControl.i18n/ru.json
diff --git a/src/components/InlineCreateGoalControl/InlineCreateGoalControl.tsx b/src/components/InlineCreateGoalControl/InlineCreateGoalControl.tsx
diff --git a/src/components/ProjectSubscriptionButtons/ProjectSubscriptionButtons.tsx b/src/components/ProjectSubscriptionButtons/ProjectSubscriptionButtons.tsx
@@ -7,6 +7,7 @@ import { useProjectResource } from '../../hooks/useProjectResource';
 import { dispatchModalEvent, ModalEvent } from '../../utils/dispatchModal';
 import { StarButton } from '../StarButton/StarButton';
 import { WatchButton } from '../WatchButton/WatchButton';
+import { createGoalInlineControl } from '../../utils/domObjects';
 
 import { tr } from './ProjectSubscriptionButtons.i18n';
 
@@ -43,9 +44,19 @@ export const ProjectSubscriptionButtons: FC<ProjectSubscriptionButtonsProps> = (
             {nullable(
                 view === 'icons',
                 () => (
-                    <Button view="clear" iconLeft={<IconAddOutline size="s" />} onClick={onAddClick} />
+                    <Button
+                        {...createGoalInlineControl.attr}
+                        view="clear"
+                        iconLeft={<IconAddOutline size="s" />}
+                        onClick={onAddClick}
+                    />
                 ),
-                <Button text={tr('Create goal')} iconLeft={<IconAddOutline size="s" />} onClick={onAddClick} />,
+                <Button
+                    {...createGoalInlineControl.attr}
+                    text={tr('Create goal')}
+                    iconLeft={<IconAddOutline size="s" />}
+                    onClick={onAddClick}
+                />,
             )}
         </>
     );