fix: avoid unnecessary query to the db

taskany-inc · Sep 6, 2024 · 461ad9d · 461ad9d
1 parent 3e00c4f
commit 461ad9d
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/trpc/queries/goals.ts b/trpc/queries/goals.ts
@@ -181,20 +181,21 @@ export const goalsFilter = async (
               },
           };
 
-    const criteriaGoalIds = await prisma.goalAchieveCriteria.findMany({
-        where: {
-            criteriaGoalId: { not: null },
-        },
-        select: {
-            criteriaGoalId: true,
-        },
-    });
+    let criteriaFilter: Prisma.GoalFindManyArgs['where'] = {};
 
-    const criteriaFilter: Prisma.GoalFindManyArgs['where'] = data.hideCriteria
-        ? {
-              id: { not: { in: criteriaGoalIds.map(({ criteriaGoalId }) => criteriaGoalId) as string[] } },
-          }
-        : {};
+    if (data.hideCriteria) {
+        const criteriaGoalIds = await prisma.goalAchieveCriteria.findMany({
+            where: {
+                criteriaGoalId: { not: null },
+            },
+            select: {
+                criteriaGoalId: true,
+            },
+        });
+        criteriaFilter = {
+            id: { not: { in: criteriaGoalIds.map(({ criteriaGoalId }) => criteriaGoalId) as string[] } },
+        };
+    }
 
     const orderBy: any = [];