fix(GoalHistory): check prev and next estimate before push

taskany-inc · Jun 21, 2023 · 2dbf15d · 2dbf15d
1 parent ca34b45
commit 2dbf15d
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/trpc/router/goal.ts b/trpc/router/goal.ts
@@ -452,14 +452,14 @@ export const goal = router({
         }
 
         const correctEstimate = await findOrCreateEstimate(input.estimate, ctx.session.user.activityId, actualGoal.id);
-
-        if (correctEstimate) {
+        const previousEstimate = actualGoal.estimate.length
+            ? String(actualGoal.estimate[actualGoal.estimate.length - 1].estimateId)
+            : '';
+        if (correctEstimate && String(correctEstimate.id) !== previousEstimate) {
             history.push({
                 subject: 'estimate',
                 action: 'change',
-                previousValue: actualGoal.estimate.length
-                    ? String(actualGoal.estimate[actualGoal.estimate.length - 1].estimateId)
-                    : '',
+                previousValue: previousEstimate,
                 nextValue: String(correctEstimate.id),
             });
         }