-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic Appveyor CI config #82
Conversation
Thanks.. Maybe some stupid questions. Are the tests passing on appveyor-ci now? How do I find out before merging? |
@webknjaz so it seems to be failing with "ERROR: InvocationError: 'C:\projects\pytest-testmon\.tox\python\Scripts\py.test.EXE --tb=native test'" . Did it work for you? |
Sorry, I didn't check, because I do not have windows machine. You may try enabling builds on AppVeyor and it would probably trigger PR build for this branch (I'm not sure). Anyway, it won't block PRs from merging unless you configure this in repo settings explicitly, thus it's harmless. If it's very important to you, I could try enabling builds for my fork. |
Here's the error happening in the project I referred to: https://ci.appveyor.com/project/CherryPy/cheroot/build/166/job/nlioynp1ls4xf3em#L215 It basically fails to guess proper encoding of files contents. |
Okay, I see you enabled it and it fails only under Python 2 @ test_easy: https://ci.appveyor.com/project/tarpas/pytest-testmon/build/4/job/faav29mb5518x0ul#L96:
|
With your cheroot project you must be hitting #14 , sorry. |
@tarpas wow, thanks for pointing that out. How can I locate that file? |
@webknjaz the last commit in master shows how to locate the file (but might bring new bugs), the last commit in fix_utf_crash is a fix, but not finished yet |
Why not rely on the coding: xyz string in the py file header? I think that's the correct way and an external library for that is unecessary. I think I'll release a new version with proper fix soon. |
sure, I just wanted to point out additional way |
Ref #81
Ref https://ci.appveyor.com