Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Appveyor CI config #82

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Jan 3, 2018

@tarpas
Copy link
Owner

tarpas commented Jan 3, 2018

Thanks.. Maybe some stupid questions. Are the tests passing on appveyor-ci now? How do I find out before merging?

@tarpas
Copy link
Owner

tarpas commented Jan 3, 2018

@webknjaz so it seems to be failing with "ERROR: InvocationError: 'C:\projects\pytest-testmon\.tox\python\Scripts\py.test.EXE --tb=native test'" . Did it work for you?

@webknjaz
Copy link
Contributor Author

webknjaz commented Jan 3, 2018

Sorry, I didn't check, because I do not have windows machine. You may try enabling builds on AppVeyor and it would probably trigger PR build for this branch (I'm not sure).

Anyway, it won't block PRs from merging unless you configure this in repo settings explicitly, thus it's harmless.

If it's very important to you, I could try enabling builds for my fork.

@webknjaz
Copy link
Contributor Author

webknjaz commented Jan 3, 2018

Here's the error happening in the project I referred to: https://ci.appveyor.com/project/CherryPy/cheroot/build/166/job/nlioynp1ls4xf3em#L215

It basically fails to guess proper encoding of files contents.

@webknjaz
Copy link
Contributor Author

webknjaz commented Jan 3, 2018

Okay, I see you enabled it and it fails only under Python 2 @ test_easy: https://ci.appveyor.com/project/tarpas/pytest-testmon/build/4/job/faav29mb5518x0ul#L96:

python runtests: commands[0] | py.test --tb=native test
============================= test session starts =============================
platform win32 -- Python 2.7.14, pytest-3.3.1, py-1.5.2, pluggy-0.6.0
rootdir: C:\projects\pytest-testmon, inifile: pytest.ini
plugins: testmon-0.9.6
collected 75 items
test\test_core.py ........................                               [ 32%]
test\test_process_code.py .......................F                       [ 64%]
test\test_subprocess.py ....                                             [ 69%]
test\test_testmon.py ........x.............s                             [100%]
================================== FAILURES ===================================
______________________ TestCoverageAssumptions.test_easy ______________________
Traceback (most recent call last):
  File "C:\projects\pytest-testmon\test\test_process_code.py", line 281, in test_easy
    msg="This is for code_sample['{}']".format(name))
  File "C:\projects\pytest-testmon\test\coveragepy\coveragetest.py", line 363, in check_coverage
    self.assertEqual(sorted(cov.get_data().lines(os.path.abspath(modname + ".py"))), cov_data, msg)
TypeError: 'NoneType' object is not iterable
========== 1 failed, 72 passed, 1 skipped, 1 xfailed in 9.44 seconds ==========
ERROR: InvocationError: 'C:\\projects\\pytest-testmon\\.tox\\python\\Scripts\\py.test.EXE --tb=native test'
___________________________________ summary ___________________________________
ERROR:   python: commands failed
Command exited with code 1

@tarpas
Copy link
Owner

tarpas commented Jan 3, 2018

With your cheroot project you must be hitting #14 , sorry.

@webknjaz
Copy link
Contributor Author

webknjaz commented Jan 3, 2018

@tarpas wow, thanks for pointing that out. How can I locate that file?

@tarpas tarpas merged commit c6a8fc2 into tarpas:master Jan 4, 2018
@tarpas tarpas mentioned this pull request Jan 4, 2018
@tarpas
Copy link
Owner

tarpas commented Jan 4, 2018

@webknjaz the last commit in master shows how to locate the file (but might bring new bugs), the last commit in fix_utf_crash is a fix, but not finished yet

@webknjaz
Copy link
Contributor Author

webknjaz commented Jan 5, 2018

@tarpas I suggest you using cchardet with fallback to chardet

@tarpas
Copy link
Owner

tarpas commented Jan 5, 2018

Why not rely on the coding: xyz string in the py file header? I think that's the correct way and an external library for that is unecessary. I think I'll release a new version with proper fix soon.

@webknjaz
Copy link
Contributor Author

webknjaz commented Jan 5, 2018

sure, I just wanted to point out additional way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants