Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using --testmon-noselect and --testmon-nocollect simultaneously #227

Closed
GytisZ opened this issue Oct 31, 2023 · 3 comments
Closed

Comments

@GytisZ
Copy link

GytisZ commented Oct 31, 2023

Is your feature request related to a problem? Please describe.
We're utilizing your project for local development and are keen to integrate testmon into our CI. However, we face a challenge when combining the --testmon-noselect and --testmon-nocollect flags. Using them together results in --notestmon due to this check.

We're trying to combine them in CI in order to preserve coverage checking while also having the checks fail as fast as possible.

Describe the solution you'd like
Please enable the simultaneous use of both --testmon-noselect and --testmon-nocollect. This can be achieved by removing the aforementioned check.

Additionally, consider updating the documentation for --testmon-noselect on testmon.org. It currently omits the feature that it reorders tests.

Describe alternatives you've considered
An ideal solution might involve more intuitive flag naming, like splitting --testmon-noselect into two flags: --testmon-noselect and --testmon-reorder. This would clarify the purpose of each flag and reduce potential conflicts.

Additional context

Are there guidelines on contributing to this project? While removing the check seems straightforward, the absence of tests suggests there might be other considerations. Is there a private codebase behind testmon.net?

@tarpas
Copy link
Owner

tarpas commented Nov 2, 2023

Thanks for suggestion. I'll still sleep on it but I think removing the check si reasonable. You're right, there is an internal codebase so yes, it's easiest I remove the line and everything else.

@GytisZ
Copy link
Author

GytisZ commented Nov 3, 2023

Thank you for considering this @tarpas . Just for additional context - noticed that there was a similar request in the comments under another issue: #86 (comment)

tarpas added a commit that referenced this issue Nov 3, 2023
@tarpas
Copy link
Owner

tarpas commented Nov 7, 2023

Released as v2.1.0, thanks for your input.

@tarpas tarpas closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants