fix: refactor istio virtualservice to support routes for REST internal and external routing, and gRPC internal routing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l and external routing, and gRPC internal routing
3 tasks
…decar injection in model registry deployment
tarilabs
reviewed
May 27, 2024
There was a problem hiding this comment.
Tested with:
export KF_TOKEN="$(kubectl -n default create token default)"
curl -H "Authorization: Bearer "$KF_TOKEN http://localhost:8080/api/model_registry/v1alpha3/registered_models
(no path prefix from CLI)
and from Notebook:
Both working as expected.
Thank you @dhirajsb
tarilabs
added a commit
that referenced
this pull request
May 27, 2024
fix: refactor istio virtualservice to support routes for REST internal and external routing, and gRPC internal routing (#2) * fix: refactor istio virtualservice to support routes for REST internal and external routing, and gRPC internal routing * fix: simplify istio config by excluding DB port and enabling istio sidecar injection in model registry deployment Co-authored-by: Dhiraj Bokde <[email protected]> Signed-off-by: Matteo Mortari <[email protected]>
tarilabs
added a commit
that referenced
this pull request
May 27, 2024
fix: refactor istio virtualservice to support routes for REST internal and external routing, and gRPC internal routing (#2) * fix: refactor istio virtualservice to support routes for REST internal and external routing, and gRPC internal routing * fix: simplify istio config by excluding DB port and enabling istio sidecar injection in model registry deployment Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Dhiraj Bokde <[email protected]>
tarilabs
added a commit
that referenced
this pull request
May 30, 2024
fix: refactor istio virtualservice to support routes for REST internal and external routing, and gRPC internal routing (#2) * fix: refactor istio virtualservice to support routes for REST internal and external routing, and gRPC internal routing * fix: simplify istio config by excluding DB port and enabling istio sidecar injection in model registry deployment Co-authored-by: Dhiraj Bokde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Merge criteria: