Remove rewrite feature #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #374 and confirmed with Dune maintainers, this way of approaching the problem doesn't work. My hope was to find a solution that can handle 80% of the tasks with 20% of the effort but it seems like due to the complexity of rewriting files that might not be in S-Expression format or be generated on build time, this feature cannot be implemented outside of dune with any kind of reliability.
Testing it on Irmin's dependencies ended up showing issues that couldn't be worked around, so instead of having a half-baked solution this PR removes all the code to reduce the maintenance burden.
Some parts might be reused later when Dune has support for subsetting similar to the one proposed here: ocaml/dune#7058 but given the code is still part of the version history it is safe to revisit it later when time comes.