Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better missing version error #248

Merged
merged 19 commits into from
Feb 15, 2022
Merged

Better missing version error #248

merged 19 commits into from
Feb 15, 2022

Commits on Feb 3, 2022

  1. Display error message when none of the versions matches 

    Closes tarides#215
    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    be903a2 View commit details
    Browse the repository at this point in the history

  2. Simplify skipping the rest of the fold using let operator

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b925c7f View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    d506432 View commit details
    Browse the repository at this point in the history

  4. Read the version_restriction from the notes 

    This has the advantage that it will not fail when there aren't any
FailsRestriction rejections.
    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    eea6334 View commit details
    Browse the repository at this point in the history

  5. Also load restriction from UserRestriction

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    a0cf396 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Add test and fix behaviour of error message

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    09a0c06 View commit details
    Browse the repository at this point in the history

  2. Fix the test 

    Thanks to @emillon for helping me debug this behavior of grep. Which is
somewhat understandable (given grep adds a \n and with -z it is a \0)
but extremely unhelpful.
    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    3eb46ff View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Revise error message

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    4f08974 View commit details
    Browse the repository at this point in the history

  2. Only pass over the model rejections once

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    3eecdc0 View commit details
    Browse the repository at this point in the history

  3. Factor out code for getting the version restriction

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    eddddf5 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Much better version error message

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    d0ab13e View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Rename no_matching_versions to a better name

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    5d8d795 View commit details
    Browse the repository at this point in the history

  2. Factor out named function for better readability

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    a76fb85 View commit details
    Browse the repository at this point in the history

  3. Add test for multiple constraints

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    5ca892d View commit details
    Browse the repository at this point in the history

  4. Collect all version constrains and And then together

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    4184f27 View commit details
    Browse the repository at this point in the history

  5. Use opam to query opam file contents

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    3ed8cf0 View commit details
    Browse the repository at this point in the history

  6. Eliminate useless use of cat 

    Co-authored-by: Nathan Rebours <[email protected]>
    @Leonidas-from-XIV @NathanReb
    Leonidas-from-XIV and NathanReb authored Feb 14, 2022
    Configuration menu
    Copy the full SHA
    67f882f View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Simplify let block 

    Co-authored-by: Nathan Rebours <[email protected]>
    @Leonidas-from-XIV @NathanReb
    Leonidas-from-XIV and NathanReb committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    da4c711 View commit details
    Browse the repository at this point in the history

  2. Add test with multiple restrictions

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    4a9621c View commit details
    Browse the repository at this point in the history