Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the full solver error with --verbose #229

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Nov 9, 2021

By default 0install-solver will display ... after the first 5 candidates. Now when --verbose is passed it displays everything.

By default 0install-solver will display `...` after the first 5
candidates. Now when `--verbose` is passed it displays everything.
CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, this results in expanding the ... ellipsis in the diagnostics right?

@emillon
Copy link
Collaborator Author

emillon commented Nov 15, 2021

Yes, that's it. I can try to add a cram test but it's likely that I'll need to add a mode that loads the opam state from a local directory.

@NathanReb NathanReb merged commit 0e48eae into main Nov 16, 2021
@emillon emillon deleted the verbose-diagnostics branch November 16, 2021 11:09
NathanReb added a commit to NathanReb/opam-repository that referenced this pull request Nov 23, 2021
CHANGES:

### Added

- Add a list subcommand to list the duniverse packages in the lockfile
  (tarides/opam-monorepo#217, @samoht)

### Changed

- Only warn users about missing dune-ports repo in OPAM switch if no solution
  can be found due to packages not building with dune (tarides/opam-monorepo#210, @Leonidas-from-XIV)
- Rename the `--repo` option to `--root` to make it more
  straightforward  that this is referring to the project root (tarides/opam-monorepo#218, @samoht)
- Improve the wording of the lockfile selection log (tarides/opam-monorepo#222, @NathanReb)
- Display the full solver error with `--verbose` (tarides/opam-monorepo#229, @emillon)

### Fixed

- Better errors for `opam-monorepo depext`, especially for non-interactive
  shells (tarides/opam-monorepo#216, @samoht)
- Properly detect all opam packages defined in the current repository, preventing it
  from later pulling duplicates into the duniverse if they were part of the target packages
  dependencies. (tarides/opam-monorepo#203, @Leonidas-from-XIV)
- Properly report missing dune-project file when trying to determine the
  to-be-genrated lockfile name (tarides/opam-monorepo#227, @NathanReb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants