Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle missing dune-project #227

Merged
merged 5 commits into from
Nov 8, 2021
Merged

Properly handle missing dune-project #227

merged 5 commits into from
Nov 8, 2021

Commits on Nov 5, 2021

  1. Refactor Project.lockfile according to recent changes 

    The name of the lockfile to generate depends on the target packages
rather than on the local ones. This both clarifies that by renaming
the labeled argument, making it mandatory and removing the unused
code path where it would try to determine the local packages itself.

Signed-off-by: Nathan Rebours <[email protected]>
    @NathanReb
    NathanReb committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    28a50fb View commit details
    Browse the repository at this point in the history

  2. Move unit tests to test/lib/ directory 

    Signed-off-by: Nathan Rebours <[email protected]>
    @NathanReb
    NathanReb committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3b43b49 View commit details
    Browse the repository at this point in the history

  3. Add a test for missing dune-project reporting 

    Signed-off-by: Nathan Rebours <[email protected]>
    @NathanReb
    NathanReb committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    af77a64 View commit details
    Browse the repository at this point in the history

  4. Properly handle missing dune-project file 

    Signed-off-by: Nathan Rebours <[email protected]>
    @NathanReb
    NathanReb committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    394a3bd View commit details
    Browse the repository at this point in the history

  5. Improve cram test 

    This moves the dune file up so it will apply to all future tests
as long as turning the test into a cram folder, incuding the files
to the tree rather than generating them as part of the test.

`cd`ing into the folder to try running commands is now possible which
should help debugging issues.
We still `cat` the content of the files so that the `run.t` file is self
contained and one does not have to browse files to fully understand the
test.

Signed-off-by: Nathan Rebours <[email protected]>
    @NathanReb
    NathanReb committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    c7ee2b0 View commit details
    Browse the repository at this point in the history