Add --keep-git-dir flag to the pull command.
#160
Conversation
rizo
force-pushed
the
add-keep-clone-flag
branch
from
e4a2403
to
7544f52
Compare
|
Rebased onto I have been using this for a while to make changes to pinned dependencies as part of duniverse. |
|
It doesn't make as much sense as it used to since we default to pulling tarballs instead of always relying on git but if you have a use for this I guess it's a good enough reason! It would be nice to have a way to propagate the local changes back into the lockfile but I guess we still need to see how people will use this option first! Sorry for the delay, I'll look into it. |
There was a problem hiding this comment.
It all looks good to me!
The clone wording, both in the CLI flag and the code trouble me a little bit here. This wording was present before your PR, probably even introduced it myself, but I wonder if it's not the right time and place to replaceclone with git_dir here to be perfectly clear what this is whole about.
The documentation is clear enough so it's not that much of a problem but I think we should at least rename the CLI flag because it's user visible, I'll take care of the renaming in the code.
Does that sound good to you? Can you rename the flag and then we can merge and cut a release!
|
Thanks for looking into this, @NathanReb!
I was also slightly concerned about this at first, but we are using git for pins which is arguably when having this flag is most needed. I would even say that keeping the repo for non-pinned deps is not a good idea because that workflow makes it harder to get reproducibility for the changes.
It would be pretty amazing. Happy to do some work on this if you have any concrete suggestions. Right now, updating the pin entry in the opam file works well enough I think. Updated the flag name as per your suggestion. |
rizo
changed the title
--keep-clone flag to the pull command.--keep-git-dir flag to the pull command.
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
CHANGES: ### Added - Add a depext subcommand to install the external system dependencies listed in lock file (tarides/opam-monorepo#207, @samoht) - Add the `--keep-git-dir` flag to the `pull` command that can be used to keep the [.git] directory after pulling the vendored sources. (tarides/opam-monorepo#160, @rizo) ### Fixed - Fix tool name in generated dune file so that it does not refer to the tool as `duniverse` (tarides/opam-monorepo#206, @emillon)
Allows to keep the pulled sources as git repositories. This in combination with having
duniversein.gitignoreresults in a nice workflow for contributing changes to vendored packages.I named the option
--keep-cloneinstead of--trim-clone=falseto keep it as a flag. I can can the name if it's not very clear.