Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out null elements that are sometimes in the nodes list #39

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

gpetiot
Copy link
Member

@gpetiot gpetiot commented Apr 4, 2024

Fix #32

The code replaced by #26 was indeed filtering the list of nodes from Null elements

The weird thing is that apparently these nulls are only produced for some people and not others, e.g. if I try to retrieve the exact same period for Jan it works for me, but fails for him.

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@gpetiot gpetiot merged commit 7cd1725 into tarides:main Apr 4, 2024
3 checks passed
@gpetiot gpetiot deleted the filter-null-elements branch April 4, 2024 12:12
gpetiot added a commit to gpetiot/tarides-opam-repository that referenced this pull request Apr 4, 2024
CHANGES:

### Fixed

- Filter out null elements that are sometimes in the nodes list (tarides/get-activity#39, @gpetiot)
gpetiot added a commit to tarides/opam-repository that referenced this pull request Apr 4, 2024
CHANGES:

### Fixed

- Filter out null elements that are sometimes in the nodes list (tarides/get-activity#39, @gpetiot)
samoht pushed a commit to samoht/tarides-opam-repository that referenced this pull request Jul 23, 2024
CHANGES:

### Fixed

- Filter out null elements that are sometimes in the nodes list (tarides/get-activity#39, @gpetiot)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get-activity.1.0.1 broken?
1 participant