Remove the delegate API #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum wait, this is useful for people not using GitHub to store their release tarballs. Can you please post at least a summary of your discussions before removing that completely? |
|
Sure! I'll do that today. I also suggest we go through a deprecation phase beforehand so we give users of that feature a chance to express themselves! |
|
#154 for more context |
|
I wrote an issue with a proposed plan here: #188. I suggest we close this PR for now as the plan to remove delegates requires quite a few steps and it's likely it will take us some time (hopefully only a few months) to actually remove the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, this API was not used by most users and was over-complicating the code.