feat: pin hickory-client and hickory-resolver #6698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_pin_hickory
branch
from
48d7e73
to
1715e08
Compare
Test Results (CI) 3 files 129 suites 36m 22s ⏱️ Results for commit 1715e08. |
|
We do not use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pined hickory-client and hickory-resolver
Motivation and Context
There was an interface change between
hickory-client v0.25.0-alpha.2andhickory-client v0.25.0-alpha.3hickory-resolver v0.25.0-alpha.2andhickory-resolver v0.25.0-alpha.3and other projects that use
"https://github.com/tari-project/tari.git"as dependency will resolve to the latter and not the former due to its lock file being generated after that of"https://github.com/tari-project/tari.git".How Has This Been Tested?
All builds succeed
What process can a PR reviewer use to test or verify this change?
Review CI builds
Breaking Changes