feat(peersync)!: push local peer record to connected peer on change #6687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 126 suites 9m 39s ⏱️ Results for commit d8cc83b. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files 10 suites 13m 55s ⏱️ For more details on these failures, see this check. Results for commit d8cc83b. ♻️ This comment has been updated with latest results. |
sdbondi
force-pushed
the
libp2p2-update-peersync
branch
2 times, most recently
from
bb03359
to
f2a4eca
Compare
sdbondi
force-pushed
the
libp2p2-update-peersync
branch
from
f2a4eca
to
4fb8fd7
Compare
sdbondi
force-pushed
the
libp2p2-update-peersync
branch
from
f93973b
to
a91b1ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(peersync)!: push local peer record to connected peer on change
Motivation and Context
Connected peers should have an up-to-date and shareable address record for peers they are connected to. This PR adds this to the peer sync protocol.
How Has This Been Tested?
Manually - looked at logs to observe it working
What process can a PR reviewer use to test or verify this change?
Given node A connected to node B prior, a node C can request node B from Node A and always get a response.
Breaking Changes
BREAKING CHANGE: peer sync protocol is not compatible with previous versions