fix(core): reduce block messages with many connections #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 37m 26s ⏱️ Results for commit 6054a99. |
ghpbot-tari-project
added
P-acks_required
SWvheerden
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(core): reduce block messages with many connections
Motivation and Context
When a seed node is connected to many hundreds of base node peers, it propagates blocks on all connections.
This PR changes this to send to 20 random peers. Default propagation_factor is changed from 4 to 20.
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes