feat(peerseeds/autoupdate): hickory-dns upgrade, default to system DNS #6600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
system-default-dns
branch
2 times, most recently
from
1e7a4b7 to
ffeb16a
Compare
sdbondi
force-pushed
the
system-default-dns
branch
from
5ac92ec to
51c3bf5
Compare
Test Results (Integration tests) 2 files 11 suites 32m 27s ⏱️ For more details on these failures, see this check. Results for commit 6f60db1. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 129 suites 35m 45s ⏱️ Results for commit 6f60db1. ♻️ This comment has been updated with latest results. |
sdbondi
force-pushed
the
system-default-dns
branch
from
f7e8f64 to
be6dd94
Compare
|
Looks like we're using an old version of gcc CI. I've added that to the CI deps install script so let's see. |
sdbondi
force-pushed
the
system-default-dns
branch
from
be6dd94 to
6f60db1
Compare
|
Guess not - I've removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade from trust dns to hickory DNS
Allow system default DNS to be used for DNS resolution
Motivation and Context
Cloudflare 1.1.1.1 was used by default and this can be blocked. Better UX to use the system default.
How Has This Been Tested?
Existing tests updated
What process can a PR reviewer use to test or verify this change?
Seed peers still work
Breaking Changes