Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make pre mine spend tx stealth #6596

Merged
merged 2 commits into from
Oct 2, 2024
Merged

feat: make pre mine spend tx stealth #6596

merged 2 commits into from
Oct 2, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Make the pre-mine spending transactions stealth tx

@SWvheerden SWvheerden requested a review from a team as a code owner October 2, 2024 12:26
@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

Test Results (CI)

    3 files    129 suites   34m 25s ⏱️
1 324 tests 1 324 ✅ 0 💤 0 ❌
3 970 runs  3 970 ✅ 0 💤 0 ❌

Results for commit 5ae48bb.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

Test Results (Integration tests)

36 tests   36 ✅  14m 31s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit 5ae48bb.

♻️ This comment has been updated with latest results.

@hansieodendaal hansieodendaal changed the title feat: Make pre mine spend tx stealth feat: make pre mine spend tx stealth Oct 2, 2024
hansieodendaal
hansieodendaal reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I just need to run some system-level tests to verify

hansieodendaal
hansieodendaal approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK (passed system-level testing)

@SWvheerden SWvheerden merged commit 7b01301 into tari-project:development Oct 2, 2024
17 of 18 checks passed
@SWvheerden SWvheerden deleted the sw_make_tx_stealth branch October 3, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

Assignees
No one assigned
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project