feat: allow zero fees for pre-mine #6595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allowed zero fees for pre-mine immediate spend - Added inputs to genesis block addition for pre-mine immediate spend
Test Results (CI) 3 files 129 suites 36m 20s ⏱️ Results for commit 3bdf311. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 23m 24s ⏱️ For more details on these failures, see this check. Results for commit 3bdf311. ♻️ This comment has been updated with latest results. |
SWvheerden
previously approved these changes
Oct 2, 2024
base_layer/core/src/transactions/transaction_protocol/transaction_initializer.rs
Outdated
Show resolved
Hide resolved
SWvheerden
reviewed
Oct 3, 2024
base_layer/core/src/transactions/transaction_protocol/transaction_initializer.rs
Outdated
Show resolved
Hide resolved
SWvheerden
reviewed
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Inputs of immediate spend transactions need to be considered in the genesis block.
How Has This Been Tested?
System-level testing [TBD] to generate a new genesis block, then unit test
xxx_genesis_sanity_checkmust pass.What process can a PR reviewer use to test or verify this change?
Code review
Breaking Changes