Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use transaction output as provided with encumber_aggregate_utxo #6594

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

Added an option to fn encumber_aggregate_utxo to use the transaction output from the blockchain or as provided from file.

Motivation and Context

When reading pre-mine from file for genesis block immediate spends, the output manager service should use the provided transaction output and not fetch it from a base node.

How Has This Been Tested?

System-level testing

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Added an option to `fn encumber_aggregate_utxo` to use the transaction output from the
blockchain or as provided from file.
@hansieodendaal hansieodendaal requested a review from a team as a code owner October 2, 2024 06:54
Copy link

github-actions bot commented Oct 2, 2024

Test Results (CI)

    3 files    129 suites   35m 42s ⏱️
1 324 tests 1 324 ✅ 0 💤 0 ❌
3 970 runs  3 970 ✅ 0 💤 0 ❌

Results for commit 3cbd102.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Test Results (Integration tests)

36 tests  +36   36 ✅ +36   15m 42s ⏱️ + 15m 42s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 2ed4203. ± Comparison against base commit 7e07972.

SWvheerden
SWvheerden previously approved these changes Oct 2, 2024
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Oct 2, 2024
@SWvheerden SWvheerden merged commit 0ad8c08 into tari-project:development Oct 2, 2024
15 of 16 checks passed
@hansieodendaal hansieodendaal deleted the ho_encumber_from_file branch October 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants