Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update pre-mine specification and allow multiple spends #6590

Merged
merged 2 commits into from
Oct 1, 2024
Merged

feat: update pre-mine specification and allow multiple spends #6590

merged 2 commits into from
Oct 1, 2024

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Sep 30, 2024 •
edited
Loading

Description

  • Updated the pre-mine specification to cater for different upfront release strategies.
  • Update pre-mine spending to consider spending multiples of multiple outputs to a single wallet.
  • Updated pre-mine spend to output immediate genesis block spends to json for inclusion in the genesis block.
  • Added reading pre-mine input from file as an option for immediate genesis block spends, instead of reading the embedded pre-mine file.

Motivation and Context

Catering for new requirements.

How Has This Been Tested?

System-level testing [TBD]

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner September 30, 2024 15:56
@hansieodendaal hansieodendaal marked this pull request as draft September 30, 2024 15:57
@hansieodendaal hansieodendaal changed the title feat: update the pre-mine specification and allow multiple pre-mine output spends to a single wallet feat: update the pre-mine specification and allow multiple spends Sep 30, 2024
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 30, 2024
@hansieodendaal hansieodendaal changed the title feat: update the pre-mine specification and allow multiple spends feat: update pre-mine specification and allow multiple spends Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Test Results (CI)

    3 files    129 suites   35m 40s ⏱️
1 324 tests 1 324 ✅ 0 💤 0 ❌
3 970 runs  3 970 ✅ 0 💤 0 ❌

Results for commit 7f3ccc1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Test Results (Integration tests)

 2 files  11 suites   35m 27s ⏱️
36 tests 33 ✅ 0 💤 3 ❌
39 runs  36 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 7f3ccc1.

♻️ This comment has been updated with latest results.

@hansieodendaal
Update the pre-mine specification
6f0ff68 
- Updated the pre-mine specification to cater for different upfront release strategies
- Updated pre-mine spend to take into account spending multiple outputs to a single
  wallet
- Updated pre-mine spend to output immediate genesis block spends to json for inclusion
  in the genesis block.
@hansieodendaal hansieodendaal force-pushed the he_pre_mine_sepc_update branch from 5d1406f to 6f0ff68 Compare October 1, 2024 06:27
@ghpbot-tari-project ghpbot-tari-project added the CR-too_long Changes Requested - Your PR is too long label Oct 1, 2024
@hansieodendaal hansieodendaal marked this pull request as ready for review October 1, 2024 09:52
@SWvheerden SWvheerden merged commit 6d998c7 into tari-project:development Oct 1, 2024
17 of 18 checks passed
@hansieodendaal hansieodendaal deleted the he_pre_mine_sepc_update branch October 1, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansieodendaal @SWvheerden @ghpbot-tari-project