Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ledger version check #6541

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat: ledger version check #6541

merged 2 commits into from
Sep 10, 2024

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Sep 9, 2024 •
edited
Loading

Description

Changed the ledger app version check from an explicit check to a min version check
Uses semver for checking

Closes: #6439

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Test Results (CI)

    3 files    129 suites   39m 27s ⏱️
1 308 tests 1 308 ✅ 0 💤 0 ❌
3 922 runs  3 922 ✅ 0 💤 0 ❌

Results for commit 1657018.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Test Results (Integration tests)

36 tests   36 ✅  15m 8s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit 1657018.

hansieodendaal
hansieodendaal approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@SWvheerden SWvheerden merged commit 611f226 into tari-project:development Sep 10, 2024
18 checks passed
@SWvheerden SWvheerden deleted the sw_ledger-version branch September 10, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimum version for ledger wallet comms test
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project