feat: add network wire byte #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added network wire byte. This is now independent from the network as byte.
sdbondi
reviewed
Sep 2, 2024
Test Results (CI) 3 files 129 suites 38m 44s ⏱️ Results for commit 24b4055. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 29m 51s ⏱️ For more details on these failures, see this check. Results for commit 24b4055. ♻️ This comment has been updated with latest results. |
hansieodendaal
force-pushed
the
ho_network_wire_byte
branch
from
0f5cda8 to
c839e89
Compare
sdbondi
reviewed
Sep 2, 2024
SWvheerden
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added network wire byte. This is now independent of the network as byte.
Note: This method in favour of #6502.
Motivation and Context
Base nodes and wallets maintained numerous connections from which they could not sync or obtain useful information. This caused base nodes to try and follow other base nodes that were on a higher proof of work but on a different genesis block, and caused wallets to query base nodes that supplied information from a different blockchain. This byte can now be changed every time the genesis block changes.
How Has This Been Tested?
Passed all unit tests.
What process can a PR reviewer use to test or verify this change?
Breaking Changes