Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check wallet type on send + ui fixes #6461

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Checks the wallet type on send in the wallet_lib
Adds various fixes for the console UI

Motivation and Context

Cleans up the Console wallet UI and makes it easier to use and only display correct info.

@SWvheerden SWvheerden requested a review from a team as a code owner August 8, 2024 14:35
Improve console wallet display
@SWvheerden SWvheerden force-pushed the sw_check_wallet_type_on_send_ branch from 137c7de to 47141b3 Compare August 8, 2024 14:37
Copy link

github-actions bot commented Aug 8, 2024

Test Results (CI)

    3 files    114 suites   37m 50s ⏱️
1 301 tests 1 300 ✅ 0 💤 1 ❌
3 710 runs  3 709 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 47141b3.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Test Results (Integration tests)

 2 files   1 errors  9 suites   11m 18s ⏱️
19 tests 18 ✅ 0 💤 1 ❌
20 runs  19 ✅ 0 💤 1 ❌

For more details on these parsing errors and failures, see this check.

Results for commit 47141b3.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@SWvheerden SWvheerden merged commit 574fa1e into tari-project:development Aug 13, 2024
14 of 17 checks passed
@SWvheerden SWvheerden deleted the sw_check_wallet_type_on_send_ branch August 13, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants