Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove domain digest #6436

Merged
merged 2 commits into from
Jul 30, 2024
Merged

chore: remove domain digest #6436

merged 2 commits into from
Jul 30, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

removes domain digest from MMR

Motivation and Context

MMR should not care what hasher you want to use.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Test Results (CI)

    3 files    123 suites   44m 42s ⏱️
1 296 tests 1 296 ✅ 0 💤 0 ❌
3 880 runs  3 880 ✅ 0 💤 0 ❌

Results for commit 512140d.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Test Results (Integration tests)

35 tests  +35   35 ✅ +35   15m 29s ⏱️ + 15m 29s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 512140d. ± Comparison against base commit 5a33bc8.

♻️ This comment has been updated with latest results.

brianp
brianp approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@SWvheerden SWvheerden merged commit f9907a8 into tari-project:development Jul 30, 2024
15 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_remove_domain_digest branch August 5, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianp brianp brianp approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @brianp @ghpbot-tari-project