feat: change grpc address conversions to use from_str #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
approved these changes
Jul 23, 2024
Test Results (CI) 3 files 111 suites 36m 2s ⏱️ For more details on these failures, see this check. Results for commit 1887397. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
the
P-acks_required
Test Results (Integration tests) 2 files 11 suites 24m 26s ⏱️ For more details on these failures, see this check. Results for commit 1887397. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chane string conversion to not assume base58. but tries all conversions using from_str.
Motivation and Context
It allows users to give hex, base58 or emoji