Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix integration tests #6378

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

fixes integration tests due to regression bug

@SWvheerden SWvheerden requested a review from a team as a code owner June 24, 2024 06:59
@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

Test Results (CI)

    3 files    120 suites   43m 7s ⏱️
1 295 tests 1 295 ✅ 0 💤 0 ❌
3 877 runs  3 877 ✅ 0 💤 0 ❌

Results for commit 2d4a9b2.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   15m 45s ⏱️ + 15m 45s
35 tests +35  34 ✅ +34  0 💤 ±0  1 ❌ +1 
36 runs  +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 2d4a9b2. ± Comparison against base commit 43b2317.

♻️ This comment has been updated with latest results.

@hansieodendaal
Copy link
Contributor

This test still fails:

All 3 runs failed: Scenario: Verify gprc cna create block with more than 1 coinbase:
Step panicked. Captured output: called `Result::unwrap()` on an `Err` value: InvalidSize
  Scenario: Verify gprc cna create block with more than 1 coinbase
   ✔  Given I have a seed node SEED_A
   ✔  When I have 1 base nodes connected to all seed nodes
   ✘  Then generate a block with 2 coinbases from node SEED_A

@SWvheerden
Copy link
Collaborator Author

SWvheerden commented Jun 24, 2024

This test still fails:

All 3 runs failed: Scenario: Verify gprc cna create block with more than 1 coinbase:
Step panicked. Captured output: called `Result::unwrap()` on an `Err` value: InvalidSize
  Scenario: Verify gprc cna create block with more than 1 coinbase
   ✔  Given I have a seed node SEED_A
   ✔  When I have 1 base nodes connected to all seed nodes
   ✘  Then generate a block with 2 coinbases from node SEED_A

A bit jumping the gun here, but its fixed now😀

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jun 24, 2024
@SWvheerden SWvheerden merged commit fbcc80c into tari-project:development Jun 24, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_fix_integration branch June 24, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants