Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make stealth one-sided tx's look the same as all other tx's #6376

Merged
merged 10 commits into from
Jun 26, 2024
Merged

feat!: make stealth one-sided tx's look the same as all other tx's #6376

merged 10 commits into from
Jun 26, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Make stealth one-sided transactions look like interactive and normal 1-sided

Motivation and Context

This increases privacy for transactions leaking less detail.

@SWvheerden SWvheerden requested a review from a team as a code owner June 20, 2024 17:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

Test Results (CI)

    3 files    120 suites   36m 9s ⏱️
1 294 tests 1 294 ✅ 0 💤 0 ❌
3 874 runs  3 874 ✅ 0 💤 0 ❌

Results for commit b30cccc.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jun 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   24m 10s ⏱️ + 24m 10s
35 tests +35  34 ✅ +34  0 💤 ±0  1 ❌ +1 
36 runs  +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit faec305. ± Comparison against base commit f42a838.

♻️ This comment has been updated with latest results.

@hansieodendaal
Copy link
Contributor

Some clippy errors

hansieodendaal
hansieodendaal reviewed Jun 22, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some comments to improve readability about the intent.

base_layer/core/src/transactions/coinbase_builder.rs Show resolved Hide resolved
base_layer/wallet/src/transaction_service/service.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/transaction_service/service.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/transaction_service/service.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/transaction_service/service.rs Outdated Show resolved Hide resolved
infrastructure/tari_script/src/lib.rs Show resolved Hide resolved
@hansieodendaal
Copy link
Contributor

Lots of integration tests failing

@hansieodendaal
Copy link
Contributor 

github-actions / Test Results (Integration tests)
All 3 runs failed: Scenario: Syncing node while also mining before tip sync: tests/features/Sync.feature:142:5

brianp
brianp previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

base_layer/wallet/src/transaction_service/service.rs Outdated Show resolved Hide resolved
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jun 26, 2024
@ghpbot-tari-project ghpbot-tari-project added the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jun 26, 2024
@SWvheerden SWvheerden merged commit 2bd58c2 into tari-project:development Jun 26, 2024
14 of 15 checks passed
@SWvheerden SWvheerden deleted the sw_hide_stealth branch June 26, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal left review comments

@brianp brianp brianp left review comments

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SWvheerden @hansieodendaal @brianp @ghpbot-tari-project