feat: generate script challenge on the ledger #6344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 120 suites 36m 0s ⏱️ Results for commit d5c9a62. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files 11 suites 22m 50s ⏱️ For more details on these failures, see this check. Results for commit d5c9a62. ♻️ This comment has been updated with latest results. |
applications/minotari_ledger_wallet/wallet/src/handlers/get_script_signature.rs
Show resolved
Hide resolved
applications/minotari_ledger_wallet/wallet/src/handlers/get_script_signature.rs
Show resolved
Hide resolved
applications/minotari_ledger_wallet/wallet/src/handlers/get_script_signature.rs
Show resolved
Hide resolved
applications/minotari_ledger_wallet/wallet/src/handlers/get_script_signature.rs
Show resolved
Hide resolved
SWvheerden
reviewed
May 17, 2024
Make the script signature function a single payload function. We're passing less data, and the previous multi function format wasn't as clean as the metadata signature. Back down to one function call is more ideal.
brianp
force-pushed
the
refactor-script-signature
branch
from
d42c801 to
d5c9a62
Compare
|
Moved the hash domains into hashing/src/. This does require making that create a I looked at using rand_core instead of ledger's random impl, but it's not no_std friendly. I'll save the byte optimizations for another PR. |
|
@brianp, please see the comment about the u64 random^ |
SWvheerden
approved these changes
May 20, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This generates the entire challenge for the script signature on the ledger.
Move signature signing functions into respective handler files.
Move hash domains into the hashing file.
Motivation and Context
The total payload size is smaller than before, and can now be done in a single message. With no batching needed I've removed the script signature context struct on the ledger side to reduce complexity, remove persisted state, and free up a bit of memory.
How Has This Been Tested?
Manually with new wallets
Breaking Changes