Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: monero merkle tree params #6336

Merged
merged 1 commit into from
May 14, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Changes how monero merge mined params are encoded and decoded

Motivation and Context

Current ones are not coded exactly correct

How Has This Been Tested?

Unit tests

@SWvheerden SWvheerden requested a review from a team as a code owner May 14, 2024 12:27
Copy link

Test Results (CI)

    3 files    120 suites   37m 46s ⏱️
1 278 tests 1 278 ✅ 0 💤 0 ❌
3 826 runs  3 826 ✅ 0 💤 0 ❌

Results for commit 92d6913.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 14, 2024
Copy link

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   14m 53s ⏱️ + 14m 53s
33 tests +33  31 ✅ +31  0 💤 ±0  2 ❌ +2 
35 runs  +35  33 ✅ +33  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 92d6913. ± Comparison against base commit 3c58600.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 14, 2024
@SWvheerden SWvheerden merged commit 9920916 into tari-project:development May 14, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_fix_mt_params branch May 15, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants