chore: prevent spam logs #6312
Merged
chore: prevent spam logs #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent spam logs from lmdb_db.rs when many inputs and outputs are present in the blockchain.
Test Results (CI) 3 files 120 suites 36m 16s ⏱️ Results for commit 1be5789. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 22m 38s ⏱️ + 22m 38s For more details on these failures, see this check. Results for commit 1be5789. ± Comparison against base commit b7b0ea3. |
SWvheerden
approved these changes
Apr 30, 2024
ghpbot-tari-project
removed
the
P-reviews_required
4 tasks
SWvheerden
pushed a commit
that referenced
this pull request
May 6, 2024
Description --- Prevent spam logs from lmdb_db.rs when many inputs and outputs are present in the blockchain - follow on to #6312. Motivation and Context --- More spam logs existed. How Has This Been Tested? --- System-level testing. What process can a PR reviewer use to test or verify this change? --- See code changes. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent spam logs from
lmdb_db.rs when many inputs and outputs are present in the blockchain.Motivation and Context
With many inputs and outputs in the blockchain the base node logs are filled up with logs fetching inputs and outputs. Important log messages go missing due to being rolled over when the file and size limits are reached.
The image below illustrates this, where 200MB log files are rolled over in less than 10 minutes.
How Has This Been Tested?
System-level stress testing.
What process can a PR reviewer use to test or verify this change?
Review code change.
Breaking Changes