Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chat ffi verbose logging options #5789

Merged

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Sep 20, 2023

Description

Adds configuration options for verbosity levels of chatffi logging.

Motivation and Context

Default levels aren't enough for debugging problems.

How Has This Been Tested?

CI

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Test Results (Integration tests)

  2 files  11 suites   21m 56s ⏱️
29 tests 28 ✔️ 0 💤 1
30 runs  29 ✔️ 0 💤 1

For more details on these failures, see this check.

Results for commit 625bab1.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Test Results (CI)

1 216 tests   1 216 ✔️  10m 13s ⏱️
     39 suites         0 💤
       1 files           0

Results for commit 625bab1.

♻️ This comment has been updated with latest results.

@brianp brianp force-pushed the build-ffis-verbose-logging branch 3 times, most recently from ddff830 to bf4ae72 Compare September 20, 2023 14:14
@brianp brianp force-pushed the build-ffis-verbose-logging branch from bf4ae72 to 625bab1 Compare September 20, 2023 17:08
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 21, 2023
@SWvheerden SWvheerden merged commit 24b4324 into tari-project:development Sep 21, 2023
12 of 13 checks passed
@brianp brianp deleted the build-ffis-verbose-logging branch September 21, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants