fix: possible exception in request_context #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
SWvheerden
changed the title
SWvheerden
previously approved these changes
Sep 19, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Fixed possible exception in 'pub struct RequestContext' that could occur when splitting the request and reply channel in 'pub fn split'
hansieodendaal
dismissed stale reviews from sdbondi and SWvheerden
via
6475ef7
hansieodendaal
force-pushed
the
ho_fix_unwrap
branch
from
025f3fd to
6475ef7
Compare
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed possible exception in
pub struct RequestContextthat could occur when splitting the request and reply channel inpub fn splitMotivation and Context
The code should not be allowed to panic in use in the wrong context.
How Has This Been Tested?
Unit tests
What process can a PR reviewer use to test or verify this change?
Code walk through
Breaking Changes