feat(chatffi): message metadata #5766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
build-ffis-feat-message-metadata
branch
from
ef28fd1
to
a184a9c
Compare
ghpbot-tari-project
added
P-acks_required
As in don't swap pointers out from under anyone. I was having a lot of trouble validating the metadata was being applied to an existing message via mutation but have since solved these issues. Now that we've verified the mutation we no longer need to destroy and create new Message objects.
brianp
force-pushed
the
build-ffis-feat-message-metadata
branch
from
f975055
to
677e4ca
Compare
SWvheerden
approved these changes
Sep 14, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a metadata field for chat messages. Metadata can be expected to hold information about a message such as it being a reply to a previous message, or it being a token request.
Motivation and Context
Enhanced chat functionality
How Has This Been Tested?
CI / Cucumber.
What process can a PR reviewer use to test or verify this change?
Breaking Changes