Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds bans for horizon sync #5661

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

Adds bans for horizon sync bad behavior
Cleans up the horizonsync errors

Motivation and Context

We should ban bad behavior, which we don't do currently.

Audit Finding Number

TARI-017

@SWvheerden SWvheerden added the C-audit_fix fixes bug found in the audit label Aug 23, 2023
@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Test Results (CI)

1 195 tests   1 195 ✔️  10m 44s ⏱️
     37 suites         0 💤
       1 files           0

Results for commit ba5ad01.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 23, 2023
@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Test Results (Integration tests)

  2 files  +  2  11 suites  +11   22m 59s ⏱️ + 22m 59s
27 tests +27  26 ✔️ +26  0 💤 ±0  1 +1 
28 runs  +28  27 ✔️ +27  0 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit ba5ad01. ± Comparison against base commit 241ca67.

♻️ This comment has been updated with latest results.

@@ -208,6 +209,7 @@ impl<'a, B: BlockchainBackend + 'static> HorizonStateSynchronization<'a, B> {
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These errors should also result in a ban

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Aug 30, 2023
@stringhandler stringhandler merged commit 826473d into tari-project:development Aug 30, 2023
@SWvheerden SWvheerden deleted the sw-horizonbans branch September 1, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-audit_fix fixes bug found in the audit P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants