feat: change default script to PushPubKey #5653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
bp-feat-pushpubkey-default
branch
from
1d5b625 to
5679d54
Compare
ghpbot-tari-project
added
P-acks_required
brianp
force-pushed
the
bp-feat-pushpubkey-default
branch
2 times, most recently
from
49c4734 to
57a6969
Compare
SWvheerden
reviewed
Aug 23, 2023
brianp
force-pushed
the
bp-feat-pushpubkey-default
branch
from
57a6969 to
7750686
Compare
brianp
changed the title
brianp
force-pushed
the
bp-feat-pushpubkey-default
branch
from
ae9c516 to
9ce20c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the default script to
PushPubKeyto ensure the spending of outputs from standard transactions is only performed with the use of specific private keys.Motivation and Context
This change to the default helps enforce that UTXOS can't be spent from a software wallet, when a hardware wallet is in use.
How Has This Been Tested?
Manually, locally, but pretty tests still require updating.
What process can a PR reviewer use to test or verify this change?
Breaking Changes