feat: ban peer unexpected response #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
sdbondi
approved these changes
Aug 9, 2023
ghpbot-tari-project
removed
the
P-reviews_required
brianp
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Ack
I looked into the test failure. Just looks like a flaky test. Passes locally for me.
I do wonder if we should ban it so quickly though. If nodes are upgrading and a new message is being sent around old nodes could ignore it and run fine, but if they don't recognize it now they could ban perfectly good nodes. Maybe we need to have some kind of limiter, like repeated bad messages, or versioning of some kind?
SWvheerden
force-pushed
the
sw_ban_unexcpected_api_response
branch
from
a46df95
to
40b4d9f
Compare
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Aug 10, 2023
…-addresses * development: chore: fix windows install (tari-project#5616) feat: ban peer unexpected response (tari-project#5608) fix!: add validator mr to mining hash (tari-project#5615) fix: check bytes remaining on monero blocks (tari-project#5610) fix: duplicate tari header in monero coinbase (tari-project#5604) fix: monero fork attack (tari-project#5603) feat: add mempool min fee (tari-project#5606) chore(tests): large block unit tests (tari-project#5599) fix: miner delay attack (tari-project#5582) fix: peer connection to stale nodes (tari-project#5579) ci(fix): artifact cleanup for diag-utils (tari-project#5613) ci(fix): update Windows installer for Minotari (tari-project#5614) chore: fixes monero build (tari-project#5612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ban a peer if they sent an unexpected message
Motivation and Context
audit finding, TARI-002