Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename tari > minotari #5597

Merged
merged 8 commits into from
Jul 31, 2023
Merged

chore: rename tari > minotari #5597

merged 8 commits into from
Jul 31, 2023

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Jul 20, 2023 •
edited
Loading

Description

This renames all user interface names from tari to minotari

Motivation and Context

This is inline with the name changes of Dan -> Tari, and BaseLayer -> MinoTari

How Has This Been Tested?

All tests
Manual inspection of log files and binaries.

@ghpbot-tari-project ghpbot-tari-project added CR-too_long Changes Requested - Your PR is too long CR-one_job CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. labels Jul 20, 2023
@SWvheerden SWvheerden changed the title schore: rename tari > minotari chore: rename tari > minotari Jul 20, 2023
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 20, 2023
@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited
Loading

Test Results (CI)

1 182 tests   1 182 ✔️  8m 57s ⏱️
     37 suites         0 💤
       1 files           0 ❌

Results for commit 811532b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited
Loading

Test Results (Integration tests)

  2 files  +  2  11 suites  +11   23m 40s ⏱️ + 23m 40s
27 tests +27  25 ✔️ +25  0 💤 ±0  2 ❌ +2 
29 runs  +29  27 ✔️ +27  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 811532b. ± Comparison against base commit 6ae34ea.

♻️ This comment has been updated with latest results.

stringhandler
stringhandler reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy in principle.

  1. I believe the capitalization should be Minotari and not MinoTari
  2. I think we should take this opportunity to rename minotari_base_node to just minotari_node

@stringhandler stringhandler merged commit b1708fc into tari-project:development Jul 31, 2023
@SWvheerden SWvheerden deleted the sw_rename_tari branch August 10, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler left review comments

Assignees
No one assigned
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. CR-one_job CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @stringhandler @ghpbot-tari-project