Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: covenants audit #5526

Merged
merged 3 commits into from
Jun 28, 2023
Merged

feat: covenants audit #5526

merged 3 commits into from
Jun 28, 2023

Conversation

hansieodendaal
Copy link
Contributor

Description

  • Added missing docs
  • Expanded some test cases
  • Added FeaturesRangeProofType and MinimumValuePromise to pub enum OutputField with associated implementations and test cases as those were missing.

Motivation and Context

Preparation for code audit

How Has This Been Tested?

Expanded unit tests for the additional output fields.

What process can a PR reviewer use to test or verify this change?

Review additions
Review docs

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal
Covenants audit
65e21f0 
- Added missing docs
- Expanded some test cases
- Added `FeaturesRangeProofType` and `MinimumValuePromise` to `pub enum OutputField`
  with associated implementations and test cases as those were missing.
@hansieodendaal hansieodendaal requested a review from sdbondi June 27, 2023 13:28
@github-actions
Copy link

Test Results (CI)

1 174 tests   1 174 ✔️  12m 57s ⏱️
     37 suites         0 💤
       1 files           0 ❌

Results for commit 65e21f0.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023 •
edited
Loading

Test Results (Integration tests)

  2 files  11 suites   38m 39s ⏱️
26 tests 23 ✔️ 0 💤 3 ❌
29 runs  26 ✔️ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 65e21f0.

♻️ This comment has been updated with latest results.

sdbondi
sdbondi approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACk

Nice

sdbondi
sdbondi previously approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACk

Nice

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jun 27, 2023
@SWvheerden SWvheerden merged commit dbb5975 into tari-project:development Jun 28, 2023
@hansieodendaal hansieodendaal deleted the ho_covenants_audit_01 branch July 27, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden left review comments

@sdbondi sdbondi sdbondi left review comments

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hansieodendaal @sdbondi @SWvheerden @ghpbot-tari-project