Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mempool): remove TODOs and other minor changes #5498

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jun 23, 2023

Description

  • Update config tests to use non-deprecated api
  • remove outdated TODOs
  • remove dead code
  • dont return internal error details back to peer (possible info leak)

Motivation and Context

Mempool audit

How Has This Been Tested?

Existing tests

What process can a PR reviewer use to test or verify this change?

Cosmetic changes

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@github-actions
Copy link

github-actions bot commented Jun 23, 2023

Test Results (CI)

1 170 tests   1 170 ✔️  24m 8s ⏱️
     37 suites         0 💤
       1 files           0

Results for commit 59d2cb2.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jun 23, 2023
@github-actions
Copy link

Test Results (Integration tests)

26 tests   26 ✔️  14m 43s ⏱️
11 suites    0 💤
  2 files      0

Results for commit 59d2cb2.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jun 23, 2023
@SWvheerden SWvheerden merged commit a1f2441 into tari-project:development Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants