feat: refactor configuration for chat so ffi can create and accept a config file #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config contains all other options we need. Peer seeds, Network, TCP info etc. This will aid in solving the problem with the chat ffi where we need to pass in a peer list. That's not easily solved from mobile. Supporting the standard config loader means we can use the config file generated from the wallet or any standard Tari app.
Instead of seed peers and a p2p config, accept a chat specific config that the ffi can also produce.
ghpbot-tari-project
added
P-acks_required
SWvheerden
approved these changes
May 30, 2023
| @@ -14,6 +14,7 @@ members = [ | |||
| "base_layer/tari_mining_helper_ffi", | |||
| "clients/rust/base_node_grpc_client", | |||
| "clients/rust/wallet_grpc_client", | |||
| # "clients/rust/web_chat", | |||
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactoring come on the heels of making testing easier via the chat configuration. As a result we also solve the problem about peer seeds in FFI. Previously the ffi required passing in a collection of peer seeds. This wasn't in any way ideal. Now we take a standard tari configuration setup, which will utilize the DNS seeds in the default configuration.
Motivation and Context
ChatFFI had a bad way to connect to peers. It needed fixing. Also cleanup of the integration tests was desired and making configuration simpler is helpful.
How Has This Been Tested?
Locally and CI
No new test was added for the configuration creation yet. As that config defaults to real config, not local config.
What process can a PR reviewer use to test or verify this change?
Breaking Changes