feat: added burn feature to the console wallet #5322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubarev
force-pushed
the
console_wallet_burn_tab
branch
from
1711fd0 to
6f611fd
Compare
agubarev
force-pushed
the
console_wallet_burn_tab
branch
from
519f0d0 to
7a51f80
Compare
SWvheerden
requested changes
May 3, 2023
ghpbot-tari-project
added
P-acks_required
| { | ||
| let bytes = if d.is_human_readable() { | ||
| let hex = <String as Deserialize>::deserialize(d)?; | ||
| from_hex(&hex).map_err(serde::de::Error::custom)? |
There was a problem hiding this comment.
It would be useful if you combine these two deserializers by trying to decode into base64 and on failure trying to decode into hex and finally erroring if neither work
| use std::str::FromStr; | ||
|
|
||
| use serde::{de::DeserializeOwned, Deserialize, Deserializer, Serialize, Serializer}; | ||
|
|
There was a problem hiding this comment.
I'm not sure what the purpose of this serializer is.
copied `serde_from` module from `tari-dan` to `tari_common_types`
…le wallet, save the proof into a file and delete claimed proofs on will
Co-authored-by: SW van Heerden <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
…split the ui types back into separate files for convenience
agubarev
force-pushed
the
console_wallet_burn_tab
branch
from
57e0a16 to
2371b2e
Compare
| @@ -1,5 +1,24 @@ | |||
| // Copyright 2022 The Tari Project | |||
| // SPDX-License-Identifier: BSD-3-Clause | |||
| // Copyright 2022. The Tari Project | |||
stringhandler
approved these changes
May 9, 2023
SWvheerden
added a commit
that referenced
this pull request
May 29, 2023
## [0.50.0-pre.2](v0.50.0-pre.1...v0.50.0-pre.2) (2023-05-29) ### ⚠ BREAKING CHANGES * add optional range proof types (5372) ### Features * add metadata signature check ([5411](#5411)) ([9c2bf41](9c2bf41)) * add optional range proof types ([5372](#5372)) ([f24784f](f24784f)) * added burn feature to the console wallet ([5322](#5322)) ([45685b9](45685b9)) * improved base node monitoring ([5390](#5390)) ([c704890](c704890)) ### Bug Fixes * **comms:** only set final forward address if configured to port 0 ([5406](#5406)) ([ff7fb6d](ff7fb6d)) * deeplink to rfc spec ([5342](#5342)) ([806d3b8](806d3b8)) * don't use in memory datastores for chat client dht in integration tests ([#5399](#5399)) ([cbdca6f](cbdca6f)) * fix panic when no public addresses ([5367](#5367)) ([49be2a2](49be2a2)) * loop on mismatched passphrase entry ([5396](#5396)) ([ed120b2](ed120b2)) * use domain separation for wallet message signing ([5400](#5400)) ([7d71f8b](7d71f8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added basic functionality to enable Minotari burning on the baselayer.
Copied
serde_frommodule fromtari-dantotari_common_typesMotivation and Context
To allow users burn Minotari to be reclaimed on the second layer (DAN).
How Has This Been Tested?
manually