ci: fail linting on truncated and wrapping casts #5233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a draft until each instance of the lint behavior is addressed in the codebase. Seems reasonable to include them all here. |
AaronFeickert
force-pushed
the
cast-off
branch
3 times, most recently
from
f9f8d1c to
88c7165
Compare
ghpbot-tari-project
added
P-conflicts
AaronFeickert
changed the title
ghpbot-tari-project
removed
the
P-conflicts
|
This has become wildly out of date, and rebasing seems like an exercise in futility. Closing so that a newer, shinier, better PR can take its place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fails linting on possible truncated or wrapping casts. Various updates to address failures.
Closes #5478.
Motivation and Context
It was observed in another PR that truncated casts are not picked up by the linter. The
clippy::cast_possible_truncationlint will catch this, but was disabled. Some of these casts may be risky, so it seems prudent to fail on them unless specifically allowed and documented.This PR enables the lint as a
deny, as well as a related lint for wrapping. For each lint failure, it either uses anallow(if the truncation is impossible or safe) or makes an update to fix it.Note that after PR 5237 is merged, it can be assumed that the target
usizeis not 32 bits.How Has This Been Tested?
It hasn't. This behavior occurs in multiple places (around a couple dozen) within the codebase; in each case, it needs to be decided if the cast is safe (in which case the lint can be selectively disabled) or risky (in which case it should be replaced). This should happen before the PR is merged.