Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic on overflow in release mode #5150

Merged
merged 2 commits into from
Jan 31, 2023
Merged

fix: panic on overflow in release mode #5150

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e265cb
fix: panic on overflow in release mode
stringhandler Jan 30, 2023
3df84a3
Merge branch 'development' into st-panic-on-overflow
stringhandler Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@ members = [
# Add here until we move to edition=2021
resolver = "2"

# Shutdown when panicking so we can see the error, specifically for the wallet
[profile.release]
panic = 'abort'
# Shutdown when panicking so we can see the error, specifically for the wallet
panic = "abort"
# By default, Rust will wrap an integer in release mode instead of throwing the overflow error
# seen in debug mode. Panicking at this time is better than silently using the wrong value.
overflow-checks = true

[patch.crates-io]
# Temporarily lock pgp to commit (master branch at time of writing) because the currently release crate locks zeroize to =1.3
Expand Down