Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve m-of-n opcode docs #4837

Merged
merged 2 commits into from
Oct 20, 2022
Merged

docs: improve m-of-n opcode docs #4837

merged 2 commits into from
Oct 20, 2022

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Oct 20, 2022 •
edited
Loading

Description

Improves the docs of the multi-sig opcodes to give a better indication of edge cases etc.
Multi-sig behavior is properly discussed here:

tari/infrastructure/tari_script/src/script.rs

Line 508 in 6227cd2

/// Validates an m-of-n multisig script

But this is a private function. Most users will only ever see the opcodes when using this.

Fixes: #4820

@CjS77 CjS77 added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Oct 20, 2022
@SWvheerden SWvheerden mentioned this pull request Oct 20, 2022
Closed
CjS77
CjS77 reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar issues

infrastructure/tari_script/src/op_codes.rs Outdated Show resolved Hide resolved
infrastructure/tari_script/src/op_codes.rs Outdated Show resolved Hide resolved
infrastructure/tari_script/src/op_codes.rs Outdated Show resolved Hide resolved
@CjS77 CjS77 added the P-merge Process - Queued for merging label Oct 20, 2022
@CjS77 CjS77 removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Oct 20, 2022
@CjS77
Copy link
Collaborator

CjS77 commented Oct 20, 2022 •
edited
Loading

ACK

@CjS77 CjS77 removed the P-acks_required Process - Requires more ACKs or utACKs label Oct 20, 2022
@CjS77 CjS77 merged commit 0201d15 into tari-project:development Oct 20, 2022
@SWvheerden SWvheerden deleted the sw_improve-n-m_script branch November 10, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjS77 CjS77 CjS77 approved these changes

Assignees
No one assigned
Labels
P-merge Process - Queued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N-of-M scripts fail if more than N signatures are provided
2 participants
@SWvheerden @CjS77